e-Contract / commons-eid

Other
14 stars 11 forks source link

BeidCards should manage the CardAndTerminalManager correctly #2

Closed hanndecl closed 8 years ago

hanndecl commented 8 years ago

Step 1: The class BeidCards creates the CardAndTerminalManager Step 2: Passes the CardAndTerminalManager to the cardManager. Step 3: When closing the BeidCards it should stop the cardManager and the CardAndTerminalManager. Otherwise the CardAndTerminalManager thread will remain. The CardManager don't stop the cardAndTerminalManager because he isn't the owner of the object.

fcorneli commented 8 years ago

Hi Hannes,

Thanks for reporting this issue. We'll have a look at it. Internal ticket: 5331 Is this a show stopper somehow?

Kind Regards, Frank.

hanndecl commented 8 years ago

Frank,

For the moment this is a non-blocking issue, but we like to add this fix as soon as possible in our release.

Kind Regards Hannes

fcorneli commented 8 years ago

Hi Hannes,

I'll schedule this for the next release.

Kind Regards, Frank.

hanndecl commented 8 years ago

Frank,

Do you have any idea on the next release date?

Kind Regards, Hannes

fcorneli commented 8 years ago

Merged fix.