search

e-alfred / epubreader

EPUB/CBR/PDF reader app for Nextcloud
GNU Affero General Public License v3.0
81 stars 21 forks source link

Cannot de-select PDF from file types for which Reader should be the default viewer #27

Open dysonsphere-startmail opened 3 years ago

dysonsphere-startmail commented 3 years ago

In Settings > Additional Settings I try to de-select Reader from opening PDFs. I get a "saving..." message that hangs. The setting never sticks.

Nextcloud: 20.0.4 EPUB/CBZ/PDF ebook reader: 1.4.5

JazMTaz commented 3 years ago

Same issue for me here also using Nextcloud 20.0.4, EPUB/CBZ/PDF ebook reader: 1.4.5

m0yP commented 3 years ago

Same here! I have several shared PDFs and when accessing them it loads the default view (which is fine) but also a pop-up window with the reader!

szaimen commented 3 years ago

Would love this, too :) Actually, this is the only issue that is preventing me from installing the app currently

rhein commented 3 years ago

This is actually the same bug as issue #20

D1reW0lf commented 3 years ago

Hi.

Just want to add my "me too" on this problem. Running EPUB/CBZ/PDF ebook reader 1.4.6 on NextCloud 20.0.9 and I can't de-select the PDF option.

Also it wouldn't be a bad idea to have a global option to prevent EPUB/CBZ/PDF ebook reader of "overtake" the PDF on the whole server and for the whole users.

Thanks Pedro

Kevin8675 commented 2 years ago

Still having this issue in 1.4.7 with NC 23. I am able to deselect it, but it will just say "Saving..." and when I reload, it is selected again.

manuelkamp commented 2 years ago

bump (is any dev here around and reading any comments?)

TheNomad11 commented 2 years ago

yeah, such a useful app, it should be part of the core actually, but I had to uninstall again because of this issue.

sysadminstory commented 2 years ago

I searched a little bit why this does not work anymore.

In the App metadata, the route to save the settings is not defined like in this documentation : https://docs.nextcloud.com/server/latest/developer_manual/basics/routing.html

I don't know how the settings are actually displayed, because there is no metadata set in this app, like in : https://docs.nextcloud.com/server/latest/developer_manual/basics/setting.html

This must have been changed at some point in some version of Nextcloud.

The code to handle the settings change is not done in a "Controller", but in a simple file : ajax/personal.php

This app need a rework to work fully in recent version of Nextcloud.

I may give it a try, but it will be a big challenge for me :o

sysadminstory commented 2 years ago

My PR #41 should fix this issue.

I'm not a Nextcloud app developper, so this PR needs to be reviewed before being production ready !