search

e-alfred / epubreader

EPUB/CBR/PDF reader app for Nextcloud
GNU Affero General Public License v3.0
79 stars 21 forks source link

Add support to NC 23 #40

Open lanawwas opened 2 years ago

lanawwas commented 2 years ago

This app cannot be installed because the following dependencies are not fulfilled: Server version 21 or lower is required.

BodoWitcha commented 2 years ago

As an administrator of a comic book archive the support on new versions of NC is very important. I second the request.

manuelkamp commented 2 years ago

it worked for me today

BodoWitcha commented 2 years ago

@manualkamp - Thanks. It worked for me too.

ickam commented 2 years ago

Guys, does it save progress for you? I tried NC 22 snap package, as well as 23 run from docker and neither of them saves read position, much to my annoyance

sysadminstory commented 2 years ago

My PR #42 should fix this (I hope !)

Mangleuz commented 2 years ago

My PR #42 should fix this (I hope !)

And it seems it did! :) Thank you for your wonderful contribution to the splendid app. It has minor quirks, but the really worst for all on Nextcloud 24 is that the reader is not compatible and installable from the app repository ;( (Issue is here). Do you perhaps know if this is just a simple meta-tag issue (23->24), or if it might break some of the nice fixes you have done?

scurrvy2020 commented 2 years ago

42 didn't seem to fix the sync for me.

sysadminstory commented 2 years ago

My PR #42 should fix this (I hope !)

And it seems it did! :) Thank you for your wonderful contribution to the splendid app. It has minor quirks, but the really worst for all on Nextcloud 24 is that the reader is not compatible and installable from the app repository ;( (Issue is here). Do you perhaps know if this is just a simple meta-tag issue (23->24), or if it might break some of the nice fixes you have done?

I'm totally not a Nextcloud App developer, so I can not be sure if it should work (I'm still using Nextcloud 22). I tried to replace the deprecated feature I saw during the fix, so Nextcloud 24 could work. You might test editing the info.xml file to change the supported version.

sysadminstory commented 2 years ago

42 didn't seem to fix the sync for me.

Do you have any request to a URL ending with "cursor" while changing pages ? What is HTTP return code for those requests ?