search

e-alfred / epubreader

EPUB/CBR/PDF reader app for Nextcloud
GNU Affero General Public License v3.0
81 stars 21 forks source link

Fix settings #41

Open sysadminstory opened 2 years ago

sysadminstory commented 2 years ago

Hello !

This is a fix for the file association settings not working #27 :

I never worked on any Nextcloud app before, so this needs to be reviewed !

I did test it only on a test Nexctloud instance !

shyzus commented 2 years ago

First off, thank you for your work on this fix. I have used this app with the fix applied and it works very well. One thing to note would be the removal of personal.php. If you could remove this it would be great. The way it currently stands there are two setting pages by removing this one it looks a lot better.

Look forward to seeing this merged. 👍

sysadminstory commented 2 years ago

Thanks for pointing this : I did not know where the "old" settings page were defined !

ummon29 commented 2 years ago

Thank you for our work on this. I tried both of your Fixes (#41, #42) an they mostly seem to work fine. The only issue I encountered is that i am now unable to open cbz/cbr files. They download but never start to extract. Switching back to 1.4.7 without your fixes they open up fine. epub and pdf are working fine. I use Nextcoud 23.0.0 with nginex. Does anyone else have this problem? I'm hoping to have everything in your fixes applied the right way.

sysadminstory commented 2 years ago

The fixes in #42 are a work in progress pull request so this can not be considered as "working", To be honest I'm lost in all those JavaScript loading each other ...

shyzus commented 2 years ago

After some more use I did some deeper digging after certain errors started popping up regarding the app being unable to find the file personal.php.

It appears that it is still required and being loaded and sometimes cached in the /ajax/ directory. If this file is not present in the root directory of the app it will throw an error in the nextcloud logs, however if it was still cached in the ajax directory it will continue to operate. Once that file is also removed then the app no longer works properly when it comes to its settings. I did some digging and found a temporary solution for this. First restoring personal.php back to its original location in the root directory as it was before commit: 9f1250a. Then modifying app.php by removing the line \OCP\App::registerPersonal('epubreader', 'personal'); This prevents it from being registered under the personal section in the additional settings submenu. This issue may also resolve @ummon29 issue since the preferences may have been not working if they didn't have a cached version of personal.php available.

ummon29 commented 2 years ago

I tried again with the personal.php in it's previous location. My app.php was already modified. The behavior is the same as before. Epub is working fine. cbr/cbz are downloaded but never start to extract.

sysadminstory commented 2 years ago

I got this issue fixed : I forgot to update the personal.js file with he new route !

devnoname120 commented 1 year ago

@sysadminstory Is anything missing for merging this pull request?

sysadminstory commented 1 year ago

@sysadminstory Is anything missing for merging this pull request?

Well, on my point of view, no, but the owner of this repo seems to be inactive :(