Limit the number of options provided by SANE backends

e-alfred / nextcloud-scanner

Scanner app for Nextcloud using the SANE framework

GNU Affero General Public License v3.0

23 stars 10 forks source link

Limit the number of options provided by SANE backends #13

Open e-alfred opened 5 years ago

e-alfred commented 5 years ago

We should limit the amount of options provided by the SANE backends as there are a lot of different options depending on the device/backend and many are rather obscure and have no purpose for our app.

Currently the most important generic options should be:

Mode (Color/Grayscale/Lineart)
Resolution in DPI
Size of file to scan including visual selection from preview

If there are any other generic options available on all backends we should include them if they are useful for the user.

Biont commented 5 years ago

@e-alfred Only the mentioned params are now whitelisted. However, the basic architecture is already in place to allow per-backend whitelists in the future

Biont commented 5 years ago

On second thought, I'd prefer to let the REST API return the full capabilities of the backends and implement the whitelist in Javascript. I would think that this is a more flexible approach since you could still use the REST endpoint for arbitrary stuff and you could easily show&hide scan parameters dynamically in case you need them.

But let's not let that become a blocker for the next release. We can change that later just as well

Biont commented 5 years ago

Turned out to be a very easy and quick change. Adding a simple "Show all parameters" should be trivial as well, but let's go easy for the moment

e-alfred commented 5 years ago

This is a good idea, so any user who wants to use some additional features of their scanner/backend can try them out if they need it. A simple warning that these features are untested could be added to warn them that not everything might work as expected.

v-sim commented 4 years ago

and scanner selector

example

$ scanimage -L
device `hpaio:/net/hp_laserjet_cm1415fn?ip=192.168.1.100&queue=false' is a Hewlett-Packard hp_laserjet_cm1415fn all-in-one
device `hpaio:/net/officejet_pro_7740_series?ip=192.168.1.102&queue=false' is a Hewlett-Packard officejet_pro_7740_series all-in-on
e

Biont commented 4 years ago

There is already rudimentary support for multiple backends in the vuejs branch (but commented out IIRC)

I really need to get back to work on this project :sleepy: