search

e-alfred / ocdownloader

ocDownloader - AGPL-licensed multi-protocol download manager for Nextcloud using ARIA2, youtube-dl and Curl (supports Youtube, BitTorrent, HTTP, FTP)
https://github.com/e-alfred/ocdownloader
GNU Affero General Public License v3.0
375 stars 85 forks source link

YouTube-dl and Ocdownloader #214

Open changemenemo opened 3 years ago

changemenemo commented 3 years ago

If ocdoWnloader, as-stated by the owner, is just a front end for aria... then I m sorry but why the hell the YouTube section does use aria... in no case whatsoever, it should use aria and if it can't find YouTube-dl then it should just give us an error message. I don't want aria take care of YouTube-dl section!!!!!!

weeman1337 commented 3 years ago

Hi @boistordu . The description is

ocDownloader is an AGPL-licensed application for Nextcloud which allows you to download files from HTTP(S)/FTP(S)/Youtube/Bittorrent using the ARIA2 download manager/Curl and youtube-dl.

If you read further you will find out that you need youtube-dl for downloading YouTube content.

Did you encounter a specific issue or bug? If so could you please describe it here in detail? Perfect would be a description on how to reproduce an issue so that someone is able to find and fix it.

changemenemo commented 3 years ago

Hi @weeman1337 I hope you are okey. I'm sorry but I'm going to be a bit harsh here and the reason for that is that I'm not convinced that you are reading, and by you I mean the owner and yourself and other contributors, the feedback that we are giving you about this app and especially about the youtube part. Aria should NOT be part of any steps in the downloading of links put into the field in the youtube selection. Youtube-dl is capable of handling ten of thousands of different websites wether it's porn, youtube, other video platform etc. And at no whatever stage we should see an aria process popping in for that. But what do we see each time we try to download something in that section ? An aria process and of course aria2c file as a result in the folder. This is bad design, there is no need wahtsoever of that and actually this is why you have dozens of tickets concerning the youtube section. And let's be honest here, it should even not be called that way but more like "media link download" section. So since none of you is decided to scroll through your issues pages I'm going to list a non-exhaustive list of all the problems I4ve reacted to during the last 6 months about this plugin of nextcloud.

https://github.com/e-alfred/ocdownloader/issues/199 https://github.com/e-alfred/ocdownloader/issues/187 https://github.com/e-alfred/ocdownloader/issues/29

And I could go on and on with this with others issues which have been unjustifiably closed or never answered to.

None of the parameters we usually do with youtube-dl does work. Youtube-dl is actually working when we are using the curl option of this ocdownloader plugin and so that we shortcut aria completely.

This has to stop now. There is no need of any technical details about it, it has been done and redone by quantity of people here to prove to you that it's not working properly.

If it was working properly, then from out of the box we should have a youtube-dl process popping up in the server and we should receive when putting simply "best" as parameters the 1080p of a video file ad you do normally in command line with youtube-dl on any platform whatsoever.

So please ONCE AND FOR ALL FIX THIS! Or if you all among the contributors think that it's working correctly, then do a gif video file to show with the process list open and the file result that you actually make youtube-dl work and that it is actually downloading 1080p video or more. And then we will be able to discuss the technical details and why on every of our instances here it's not working as intended by you. But the result here is that we only receive this as videos: 

<html><body>
<!--StartFragment-->

Length: | 00:03:06
-- | --
Dimensions: | 640 x 360
Frame rate: | 25 fps
Bit rate: | 710 kbps
Video codec: | H.264 - MPEG-4 AVC (part 10)
Audio codec: | ISO/IEC 14496-3 AAC
Audio channels: | 2
Audio sample rate: | 44.1 kHz
Audio sample size: | 16 bit

<!--EndFragment-->
</body>
</html>

15MB of video file where we try with youtube-dl on any other platform, a 150 MB video file for 1080p and much better audio.

So unless you are really dedicated to work with me to actually resolve this section of the plugin once and for all so that we can actually document the how to do step to avoid any quirks.......

Still have a nice day