e-alfred / ocdownloader

ocDownloader - AGPL-licensed multi-protocol download manager for Nextcloud using ARIA2, youtube-dl and Curl (supports Youtube, BitTorrent, HTTP, FTP)
https://github.com/e-alfred/ocdownloader
GNU Affero General Public License v3.0
375 stars 85 forks source link

It is not compatible with NC25 #250

Open anguschang007 opened 2 years ago

anguschang007 commented 2 years ago

Screenshot at Oct 25 21-04-13 The app is not compatible with NC25. The right side section is missing!

Albirew commented 2 years ago

On my side, i get an error 500-like, and an exception in logs Exception: OC\Files\Utils\Scanner::__construct(): Argument #4 ($logger) must be of type Psr\Log\LoggerInterface, OC\Log given, called in /path-to-nxc/apps/ocdownloader/controller/index.php on line 249 in file '/path-to-nxc/lib/private/Files/Utils/Scanner.php' line 95

anguschang007 commented 2 years ago

On my side, i get an error 500-like, and an exception in logs Exception: OC\Files\Utils\Scanner::__construct(): Argument #4 ($logger) must be of type Psr\Log\LoggerInterface, OC\Log given, called in /path-to-nxc/apps/ocdownloader/controller/index.php on line 249 in file '/path-to-nxc/lib/private/Files/Utils/Scanner.php' line 95

https://github.com/e-alfred/ocdownloader/pull/247

weeman1337 commented 2 years ago

There is not even proper support for 24 yet, although a ready PR exists #247 .There was a commit updating the app info without migrating the rest. I am removing myself as a collaborator @e-alfred . The reason is that I don't want to put time into this project if the work is ignored :frowning_face:

firebird76 commented 2 years ago

Screenshot at Oct 25 21-04-13 The app is not compatible with NC25. The right side section is missing!

@anguschang007: You can fix the problem: Change <div id="app"> in templates files to <div id="content">.

MasterBean7 commented 1 year ago

Thanks for point it out @firebird76 In fact, on my version NC25.0.1 it looks better if the \<dav> is removed completely. However, the automatic reload still creates a "glitch" effect. And workaround #247 was needed.

p-bo commented 1 year ago

Just in case it wasn't noticed - Nextcloud improved policy regarding changes in core to ease app developers in maintaining compatibility with newer Nextcloud versions:

https://help.nextcloud.com/t/new-process-for-documenting-core-code-changes-that-affect-app-developers/149828?u=p-bo

31337-4554551n commented 1 year ago

I am also saddened this app isn't getting love. Commenting to get updates if this is ever resolved. This app was one of the reasons I love nextcloud. @weeman1337 Are you aware of any forks perhaps? Any interest in creating your own? :P

freechelmi commented 1 year ago

NcDownloader is a good candidate https://apps.nextcloud.com/apps/ncdownloader

31337-4554551n commented 1 year ago

NcDownloader is a good candidate https://apps.nextcloud.com/apps/ncdownloader

You're an absolute legend! Had no idea this existed.

None of these have an android companion app though, do they?

e-alfred commented 1 year ago

Due to personal reasons, I did not have as much time during the last months for maintaining all the Nextcloud apps I used to do for several years now.

One mistake was to release of a bogus version without the required fix that should have been packaged. I am very sorry for that, but keeping up was not as easy as it was before. I hope I can do more releases in the future again.

NTenic-Hadrev commented 1 year ago

Just in case someone wants to try it. NCDownloader is not working well.

meichthys commented 1 year ago

Also for reference, not compatible with NC26