e-chan1007 / nuxt-monaco-editor

Integrate monaco-editor with Nuxt
https://e-chan1007.github.io/nuxt-monaco-editor
MIT License
114 stars 15 forks source link

Never disposed onUnmounted #31

Closed starnayuta closed 9 months ago

starnayuta commented 1 year ago

There is never any dispose in MonacoEditor.client.vue and MonacoDiffEditor.client.vue.

The monaco-editor samples and other similar libraries that use it often dispose on unmount.
https://github.com/microsoft/monaco-editor/blob/main/samples/browser-esm-vite-react/src/components/Editor.tsx#L21

Here is a description of disposables.
https://github.com/microsoft/monaco-editor#disposables

Here is a list of targets for disepose, which varies with each library.

e-chan1007 commented 9 months ago

This was fixed in v1.2.4.