search

e-dant / watcher

Filesystem watcher. Works anywhere. Simple, efficient and friendly.
MIT License
639 stars 32 forks source link

include atomic in Linux and Android #35

Closed toge closed 11 months ago

toge commented 11 months ago

In code for Linux, std::atomic_bool is required. https://github.com/e-dant/watcher/blob/release/0.9.0/include/wtr/watcher.hpp#L1550

But <atomic> is not included. It causes a compilation error.

This PR try to fix it.

e-dant commented 11 months ago

LGTM, but can we merge into the next branch, and add the same line to: https://github.com/e-dant/watcher/blob/next/devel/include/detail/wtr/watcher/adapter/linux/inotify/watch.hpp#L11

Also, if it's easier, I usually edit the files in devel/include directly, then just run tool/hone --header-content-amalgam > include/wtr/watcher.hpp, but editing both sets of files has the same effect.

TYVM

toge commented 11 months ago

@e-dant Thanks a lot for detail information. I try to provide a simple patch for conan packaging only for 0.9.0.

I close this PR. Looking forward to the next Watcher release!