search

e-dant / watcher

Filesystem watcher. Works anywhere. Simple, efficient and friendly.
MIT License
639 stars 32 forks source link

watcher.hpp includes C++20 standard library <bit> #37

Closed saukijan closed 9 months ago

saukijan commented 10 months ago

Hi @e-dant, thanks for your work on issue #32, however, pure C++17 support is still not available.

wtr/watcher.hpp includes the bit library header, which was introduced in C++20 and is preventing compilation on older systems (for example Debian buster).

Is this header needed?

e-dant commented 10 months ago

No, it's not. I must have introduced that by mistake. I was fiddling with bit_cast, which is included in the bit header, but memcpy is roughly equivalent. If bit_cast is used anywhere, it's by mistake. I'll fix that.

e-dant commented 10 months ago

Our CI needs some work. We should figure out how to use GH actions with containers for better control over the environment. Or even just request an older version of the provided Ubuntu runners.

saukijan commented 10 months ago

No problems @e-dant, thanks for the response and clarification.