Closed kc9jud closed 2 years ago
The “before” values came from the commit immediately prior.
On Monday, Oct 11, 2021 at 13:32, Soham Pal @. @.)> wrote:
@kc9jud (https://github.com/kc9jud) Which commit / branch did you use for the before values?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub (https://github.com/e-eight/chime/issues/8#issuecomment-940219278), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AA7RGDF5H2DF4YFVLPJPOZLUGMNUDANCNFSM5FXUSIWA).
This is because I changed the phase convention of the 3DHO basis functions to "positive at origin" in e-eight/basis_func@5374e4c034c4d25c019d9338ac9c0ec39929dd70
@kc9jud Does that answer your question?
@e-eight I'm finally getting back to this -- I'm trying to benchmark against your slides from 2020-04-29 and I can't seem to reproduce the numbers for 3He with the newer version. However, I do get the same numbers if I use the old commit. In addition, in heavier nuclei I get really strange results if I use the newer version. Can you confirm that you're still getting the same numbers as back in those slides?
Closed by #9.
It appears a phase error has been introduced in 2641065da5c25ee02b09762184af4cd6c29443f7.
relativecm-gen
inputrelcm.in
:Before:
After:
Many of the other matrix elements differ in phase, but this is just the first few.