e-gineering / gitflow-helper-maven-plugin

An extension and plugin that teaches Maven to work well with gitflow projects and CI servers.
Apache License 2.0
76 stars 21 forks source link

gitflow-helper-maven-plugin is not compatible with maven plugins that rewrite the POM file #127

Open glimmerveen opened 2 years ago

glimmerveen commented 2 years ago

When you have a project that uses a maven plugin that rewrites the POM file (such as the flatten-maven-plugin) in combination with the gitflow-helper-maven-plugin, you'll notice that the rewritten POM file(s) are correctly uploaded to the stage repository, but not to the releases repository.

The issue is that when the build on master executes, it does download all artefacts that were build and deployed to stage, except the POM file itself. As a result, the POM file finally published into the releases repository is not the same as the one deployed to stage, but the POM file from git itself in case a plugin is activated that tries to rewrite the POM file (ie. flatten-maven-plugin).

glimmerveen commented 2 years ago

Submitted PR #129 that adds a feature that provides means for the described use-case to work.