search

e-gov / cvi

Common Visual Identity components built upon the original Veera Design System for Open Source usage.
https://e-gov.github.io/cvi/
MIT License
7 stars 23 forks source link

Fix accessibility issues with breadcrumbs component #82

Open certainlyakey opened 1 year ago

certainlyakey commented 1 year ago

What happened?

The breadcrumbs component lacks accessibility (and usability partially is also hurt) - href attribute is missing (see eg. here why this is an issue). The links in the breadcrumbs must have URLs provided.

As a part of this issue all necessary optimisations allowing for the best experience in a screen reader should be done (based on testing with screen reader software). Eg. nav or aria-label could help with the correct comprehension of the component in assistive devices as a "proper" breadcrumbs widget.

Reproduction steps

  1. Go to https://e-gov.github.io/cvi/?path=/story/angular-breadcrumbs--default
  2. Check the generated markup
  3. Expected: links have hrefs
  4. Observed: hrefs are absent

Screenshot

No response

Package

Angular

Version

1.8.0

Reproduction URL

https://e-gov.github.io/cvi/?path=/story/angular-breadcrumbs--default

Browser

No response

Browser version

No response

Extra details about your environment

No response

Relevant log output

No response

certainlyakey commented 1 year ago

@ekateriinal is working on it.