search

e-imaxina / cordova-plugin-deeplinks

Cordova plugin to support Universal/Deep Links for iOS/Android.
MIT License
33 stars 68 forks source link

Fix Cordova 9 support #10

Closed DURK closed 5 years ago

DURK commented 5 years ago

Replace context.requireCordovaModule with normal require where needed.

Bruno361 commented 5 years ago

Hello, Could you please merge this pull request, as it is indeed all that is needed to build with Cordova 9 ?

joelchrist commented 5 years ago

@Bruno361 feel free to use the Moreapp:fix/corodova-9 branch for now, as we're doing the same thing.

DURK commented 5 years ago

Hello, Could you please merge this pull request, as it is indeed all that is needed to build with Cordova 9 ?

It's up to @juanmiguelbesada to review and merge this PR.

In the meantime you can use this branch, simply by setting this in your package.json: "cordova-plugin-deeplinks": "github:MoreApp/cordova-plugin-deeplinks#fix/cordova-9"

Bruno361 commented 5 years ago

Thanks to all for your suggestions, I actually already forked the project and use the fixed version. I was going to make the same PR as @DURK and saw that you already suggested the modifications. It would be nice to have it merged, though, so we can continue to use it through the npm package.

shanebdavis commented 5 years ago

I see this has been fixed in version 1.1.1, but 1.1.1 isn't up on npm yet (as-of June 20th 2019). When do you think you'll be able to push it to npm to ease plugin installation? Thanks for the great lib!