e-m-b-a / emba

EMBA - The firmware security analyzer
https://www.securefirmware.de
GNU General Public License v3.0
2.49k stars 223 forks source link

f10 + p99 csv files question #1116

Closed torabi12 closed 2 months ago

torabi12 commented 3 months ago

Describe the bug In f10_license_summary.csv file the last column goes into new line, if I import it into Excel column7's value is displayed in column2: Notepad++: image

Excel: image

In p99_prepare_analyzer.csv file the header values are missing, only the values are available.

I got the same for different tests as well.

To Reproduce Steps to reproduce the behavior:

  1. EMBA installation default mode
  2. Use the firmware available here: any binary
  3. Start EMBA with the following parameters: sudo ./emba -l -f -p ./default-scan.emba -X -Y -Z -N comment
  4. check f10 and p99 csv's

Expected behavior f10 should contain only one line for the same values. p99 should contain header info.

Screenshots See above.

Desktop (please complete the following information):

Priority issue Are you already a Sponsor? - [N]

m-1-k-3 commented 3 months ago

I have seen such an issue last week in other modules. Thought I fixed it ... could you check it with the latest master?

torabi12 commented 3 months ago

Yes, it is in progress, maybe it will last for longer but will come back as soon as it is finished.

torabi12 commented 3 months ago

f10 first 3 lines:

binary/file;version_rule;version_detected;csv_rule;license;static/emulation;
/logs/firmware/unblob_extracted/firmware_extract/1022440-2925450.squashfs_v4_le_extract/bin/busybox;NA;1.19.4;NA;GPL-2.0-only
;static;

p99 first line:

/logs/firmware/unblob_extracted/firmware_extract/1022440-2925450.squashfs_v4_le_extract/usr/bin/lua;ELF32;2's complement, big endian;MIPS R3000;0x70001005,noreorder,cpic,o32,mips32r2;;ELF 32-bit MSB executable, MIPS, MIPS32 rel2 version 1 (SYSV), dynamically linked, interpreter /lib/ld-uClibc.so.0, no section header;b410ffd29e45a033782cecce49b80ae6;

I think the problem is still exists.