e-m-b-a / emba

EMBA - The firmware security analyzer
https://www.securefirmware.de
GNU General Public License v3.0
2.62k stars 229 forks source link

var cleanup, status_bar fix #1132

Closed m-1-k-3 closed 5 months ago

m-1-k-3 commented 5 months ago

Bug fix

helpers local/export vars status bar issues

fixed vars status bar should work better - closes https://github.com/e-m-b-a/emba/issues/461 closes https://github.com/e-m-b-a/emba/issues/1070

m-1-k-3 commented 5 months ago

ping @torabi12

torabi12 commented 5 months ago

I changed the terminal size many times during the scan, it was working fine in small:

kép

in big: kép

Rarely the refresh was not perfect: kép

But after resizing again it was ok. At the end was like this:

kép

In summary the behaviour is much better than before with status bar. Thank you!

m-1-k-3 commented 5 months ago

@torabi12 should also address https://github.com/e-m-b-a/emba/issues/1070

torabi12 commented 5 months ago

@torabi12 should also address #1070

I can check the #1070 tomorrow I hope. May I try again the status bar test today?

m-1-k-3 commented 5 months ago

status bar looks good to me. The artefacts are looking quite small. If they do not destroy the rest of the behavior it is fine for me

torabi12 commented 5 months ago

status bar looks good to me. The artefacts are looking quite small. If they do not destroy the rest of the behavior it is fine for me

Yes, it was appropriate. Thanks again!