e-m-b-a / emba

EMBA - The firmware security analyzer
https://www.securefirmware.de
GNU General Public License v3.0
2.49k stars 223 forks source link

module_blacklist.txt gets ignored with default-scan.emba profile #1167

Closed torabi12 closed 1 month ago

torabi12 commented 1 month ago

Describe the bug I wanted to disable S14 module in module_blacklist.txt file and I used the default-scan.emba profile for testing and the S14 was running. The module dependency is a complex thing and sometimes a scan is stucked with a module for days. In this case I would like to repeat it without the never ending modul but module_blacklist.txt and default-scan.emba profile looks like do not work together.

To Reproduce Steps to reproduce the behavior:

  1. EMBA installation (dev-mode/default mode)

  2. Use the firmware available here: https://github.com/dougcooper/kankun/blob/master/kkeps-3.5.bin

  3. Start EMBA with the following parameters: $ sudo ./emba -l ~/Kankun -f ~/kkeps.bin -p ./scan-profiles/default-scan.emba -X 1.0 -Y Kankun -Z SmartPlug -N kkeps.bin

  4. add S14 to module_blacklist.txt before test run:)

  5. Check S14 test report.

Expected behavior In general a module dependency chart would be nice for the future. The blacklist config file should be valid with each profile.

Screenshots

kép

kép

kép

kép

Desktop (please complete the following information):

Priority issue Are you already a Sponsor? - [N]

m-1-k-3 commented 1 month ago

looks as we are overriding it with the profile settings. Should be easy to fix

torabi12 commented 1 month ago

I started a new scan with disabling S12, S13 and S14:

kép

but all of them are running with default-scan.emba profile.