fix status calc on non phase output

e-m-b-a / embark

EMBArk - The firmware security scanning environment

https://www.securefirmware.de

MIT License

313 stars 46 forks source link

fix status calc on non phase output #201

Closed BenediktMKuehne closed 2 months ago

BenediktMKuehne commented 4 months ago

Fixe calculation when no phase changes occur

torabi12 commented 3 months ago

I think this issue belongs to this section:

The progress bar cannot follow the real scan's state.

BenediktMKuehne commented 3 months ago

Does the PR fix the issue? I was only able to test it on a single firmware

torabi12 commented 3 months ago

I am going to try it, I need some days...

torabi12 commented 3 months ago

My new test try was hanging at 46% for a day. Some Radare related processes were running and I killed them but they started again and again. So I stopped the test and restarted it with disabled S12, S13, S14, S15 and S16. I hope this outcome will be better.

torabi12 commented 3 months ago

Sorry, but I got the same with this modified release:

If you need some files or info from the system please let me know...

BenediktMKuehne commented 3 months ago

Will check this Do you have a testing firmware for me?

torabi12 commented 3 months ago

Will check this Do you have a testing firmware for me?

I sent it to you in email.