search

e-m-b-a / embark

EMBArk - The firmware security scanning environment
https://www.securefirmware.de
MIT License
319 stars 46 forks source link

Firmware delete #38

Closed torabi12 closed 2 years ago

torabi12 commented 2 years ago

Describe the bug If I delete an uploaded firmware the EMBArk web page displays error messages.

To Reproduce Steps to reproduce the behavior:

  1. EMBArk installation (default mode)
  2. Start EMBArk: sudo ./run-server.sh
  3. Upload any FW file
  4. Do a scan
  5. Try to delete the uplaoded FW
  6. See error

Expected behavior Deletion should be working.

Screenshots kép

Desktop (please complete the following information):

m-1-k-3 commented 2 years ago

Thank you for reporting. As soon as you are using the firmware for an analysis the firmware is used and locked. But you are right, we should include a nice message for this.

torabi12 commented 2 years ago

The scan has been finished and nothing was running. I just went back the the upload page and selected the 1st file and wanted to delete it and got the above error. After I pushed the back button in the browser EMBArk page came back with a popup saying the firmware is deleted but the file remained on the list and the delete was not done. It is easy to reproduce but this was my experience.

m-1-k-3 commented 2 years ago

As soon as you have a scan of the firmware this firmware file is used and can't be deleted anymore.

torabi12 commented 2 years ago

I thought the delete function can be used for any uploaded file, after 20 or more scans the list is very long and it would be great the maintain the environment and drop out the obsolete bins. I think you should somehow display a message for this function or consider just to remove it. This is only my opinion, maybe you will have a better solution.

Thanks and regards, Torabi

m-1-k-3 commented 2 years ago

for sure we need to improve the firmware handling process in the future. There are also multiple other features around this topic missing. I will mark this issue as enhancement.

torabi12 commented 2 years ago

Hello Benedikt,

I checked again the firmware delete feature but it is not working on my side. I did an EMBArk scan and I tried to delete it but I got an error, I logged out, stopped the server., restarted it, logged in tried again to delete but same error came: kép

It is a brand new installation Kali 2022.1 with apt full-upgrade before the EMBArk install and the installation was without any error.

Does the FW delete work on your side? Or may I did something wrong?

Regards, Torabi

BenediktMKuehne commented 2 years ago

45

m-1-k-3 commented 2 years ago

Please check the latest Master. Should be fixed now.