search

e-m-b-a / embark

EMBArk - The firmware security scanning environment
https://www.securefirmware.de
MIT License
314 stars 46 forks source link

Os change #49

Closed BenediktMKuehne closed 2 years ago

BenediktMKuehne commented 2 years ago

❗ EMBArk is changing to Ubuntu:jammy (Ubuntu 22 LTS). To make containerization and development easier, Kali-Linux will no longer be the base OS for testing and development.

What kind of change does this PR introduce?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

https://github.com/e-m-b-a/emba/pull/258

m-1-k-3 commented 2 years ago

looks good. Please check the notes. I will do another functionality check and then we are set good to go

torabi12 commented 2 years ago

Hello Benedikt,

I tried the EMBArk installation on Ubuntu 22.04 LTS, it was a new installaton and I manually installed python3.9 before I started the EMBArk installer with -d.

During the installation I got some errors, please see the attachments: kép

kép

kép

I am not sure, maybe I tried too early the installation on Ubuntu, but I wanted to share with you my experiences.

Best regards, torabi

BenediktMKuehne commented 2 years ago

Hi @torabi12 ,

I'm guessing you tried the embark:main branch? Once this PR is merged the installation EMBArk should work as expected. Sorry 😅 Switching to ubuntu was more complicated than expected

torabi12 commented 2 years ago

Hello Benedikt,

I installed Ubuntu 22.04 LTS with default parameters in VMWare Workstation and I added python3.9 with these comands: $ sudo apt update $ sudo apt install software-properties-common $ sudo add-apt-repository ppa:deadsnakes/ppa $ sudo apt install python3.9

and the basic EMBArk installation came: $ git clone https://github.com/e-m-b-a/embark.git $ cd embark $ sudo ./installer.sh -d

Without python3.9 I got other errors but now I don't know how to fix the actual issues:) If python3.9 is needed for EMBArk can you put a verification into the installer and download it automatically within EMBArk installation? I thin Ubuntu does not contain this by default.

If I can try another branch please let me know how to do it and I will try another installation as well.

Regards, torabi

BenediktMKuehne commented 2 years ago

@torabi12 git clone https://github.com/BenediktMKuehne/embark -b os-change

Feel free to note any issue you encounter.

torabi12 commented 2 years ago

Hello Benedikt,

I installed this morning EMBArk using your source: https://github.com/BenediktMKuehne/embark

there were some minor warnings during the instalation, please verify them which one is valid or needs modification. I insert the images like in the command line from up to down starting from IF20_cve_search part:

kép

kép

kép

kép This is displayed 3 times in this section.

And the last one: kép

When I started EMBArk I got this: kép

and this: kép

I did a short scan with EMBArk to see the basic functions: kép

but on the report page the firmware version ignores the dots. Under that the device skipped the spaces and the notes are also: kép

I think in the report is used to be identical but now the report sometimes cuts out parts which is not user friendly. The version number would be the most important because it always contain . or - and sometimes other character and it can be long and if we skip these the reading is not comfortable.

Firmware delete was working fine. :)

Regards torabi

BenediktMKuehne commented 2 years ago

Hi @torabi12, at this point I'm not bothering with pip-warnings to much, as long as the modules work. (There is to much changing right now) There apparently is also a general issue with python-pip and the setup.py, which is unrelated to EMBArk.

The dbus-error could be related to EMBAs new status-bar. Looks like a bug Are you on a desktop or a server-version of ubuntu 22.04 LTS ? If you could open a issue in EMBA that'd be helpful.

Regarding the report: Yes, currently user-input gets filtered. In the future I'll remove the EMBA-flags with direct user-input completely. Reason being unfiltered user-input (direct command-injection) was possible. I know it's a bit annoying right now. Sorry 🤷

Thanks for the feedback

torabi12 commented 2 years ago

Thank you, I opened a bug for EMBA: dbus-launch error #284 I am using Ubuntu desktop.

torabi12 commented 2 years ago

I tried the main branch also and the installation went through but the EMBArk start looks bad: kép

during the installation I think you have mentioned this error already: kép