search

e-merlin / eMERLIN_CASA_pipeline

This is CASA eMERLIN pipeline to calibrate data from the e-MERLIN array. Please fork the repository before making any changes and read the Coding Practices page in the wiki. Please add issues with the pipeline in the issues tab.
GNU General Public License v3.0
14 stars 11 forks source link

Updated detection of pipeline path to work with CASA 5.1.1 #88

Closed celeritas closed 6 years ago

celeritas commented 6 years ago

If the pipeline is run from the same directory as the data, CASA 5.1.1 would crash as the previous lines would add '/' to the path instead of the current directory. The os.path.abspath in the second line prevents this from happening. Note: the current directory was in the CASA path by default for CASA 5.0.0 so the pipeline did not crash for this version.

The first line which sets pipeline_filename is now updated to not require numpy.

jmoldon commented 6 years ago

Thank you Katherine. Looks great. The only detail is that the try/except needs to be there in case you want to run the pipeline from an already running CASA session. In that case the sys.argv value will not exist (that is why the user has to define pipeline_path manually in that case).

Remember also to change line 13 to version v0.7.3. Could you make those two changes?

Thanks for the contribution!