search

e-merlin / eMERLIN_CASA_pipeline

This is CASA eMERLIN pipeline to calibrate data from the e-MERLIN array. Please fork the repository before making any changes and read the Coding Practices page in the wiki. Please add issues with the pipeline in the issues tab.
GNU General Public License v3.0
14 stars 11 forks source link

Potential speed up when making mms & hanning smoothing #97

Closed jradcliffe5 closed 5 years ago

jradcliffe5 commented 6 years ago

Hi Javier,

Was just using the pipeline and thought it may be quicker to do the mms step & hanning smoothing step together using just mstransform?

I'm not sure whether you've tested this or not

jmoldon commented 6 years ago

Yes, I'm reviewing the performance of that part of the code. The obvious thing I was going to do is to change the order of hanning and ms2mms, currently hanning happens before, which makes no sense. Hanning is much faster just by doing it after mms: from 1h to just 7-8min.

Including both in a single step is a good idea because I have not seen any case in which you really needed to check or modify any of those straightforward transformations. Will do that.

jradcliffe5 commented 6 years ago

Wow ok, that's a pretty substantial speed-up.

jmoldon commented 5 years ago

Resolved by #100