search

e-mission / e-mission-docs

Repository for docs and issues. If you need help, please file an issue here. Public conversations are better for open source projects than private email.
https://e-mission.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
15 stars 34 forks source link

Figure out how trip editing should work #374

Open shankari opened 5 years ago

shankari commented 5 years ago

I now have requests from three teams for the ability to edit trips, not just choose the mode and purpose. I think that three is enough critical mass that we can build this into the platform instead of making it client-specific functionality.

Requirements so far:

  1. From @asiripanich,

    I think there should be a way for user to segment the trip or add more info into the trip. For example, if I go to buy lunch at the cafeteria it is not so obvious where I made the stop but instead it registered the whole trip as me going somewhere and return to where I initially started.

  2. From @PatGendre

    If the user waits at a transit stop for ~ 10 minutes, then the trip is split, although they really continued after that

  3. From @jf87

    Would it be possible to also add the feature to let users tag the modes of single segments in the detailed view of a trip? For example, below is a trip which consists in reality of walk, bus, metro, walk.

What has been done so far:

@sunil07t wrote an initial version of a feature to split the trip from detail screen and select the mode for each trip (https://github.com/e-mission/e-mission-phone/pull/308). He did do some testing (see screenshots in the PR); however, I have not tested it myself. I am not sure that the code is very pretty since it was written when he was a sophomore :)

@sebapastore picked up the change as part of the Paraguay deployment, and submitted an updated PR, but did not indicate whether it was tested (https://github.com/e-mission/e-mission-phone/pull/469)

Will users actually use this?

My advisors believe that users will never actually edit the trip segments because it is just not central enough to their lives. So we have not prioritized this so far.

Next steps?

Can somebody try to test out the changes by @sebapastore or @sunil07t to see whether they actually work? That will give us a sense of how much work is involved to resurrect the change. Maybe we can include it anyway as an option and see how many users actually use it.

Given my backlog, I am probably not going to get to this for at least 2 weeks, so it would be good if somebody else could test it out and post their findings here.

PatGendre commented 5 years ago

Hi, thanks for adding this as an new issue. As far as I am concerned it is interesting but definitely not urgent (sorry I won't test the existing trip split feature), and we can take time to better describe the feature. For instance, a full edition of the trip (segmentation into sections) may not be relevant for a phone UI, it may sufficient to edit the mode for each sections once they have been created by the pipeline (hence the feature would not be available right after the trip end, the pipeline would have to be run on the data).

Concerning the current mode/purpose edition feature, this issues means that we could precise in the documentation that the user can enter/edit the "main mode" of each trip (not "the" mode, as many trips are multimodal).

PatGendre commented 5 years ago

Hi @shankari, I installed the app https://en.trivector.se/it-systems/travelvu/ recommended by a colleague tester. The UI is definitely very nice, the user can edit trips-section / stops-places and delete sections in a very intuitive fashion. (with the difficulty that deleting trips/sections pose problems with the current e-mission data structure). It is a mid term feature, certainly but @DO3B could certainly have a look!