search

e-mission / e-mission-docs

Repository for docs and issues. If you need help, please file an issue here. Public conversations are better for open source projects than private email.
https://e-mission.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
15 stars 34 forks source link

docker containers with development environments #504

Open shankari opened 4 years ago

shankari commented 4 years ago

I've been playing around with docker and exploring how best to use it to set up easy to use environments.

I already used it to create a containerized multi-tier architecture with separate server and analysis tiers (https://github.com/e-mission/e-mission-docker/pull/4). @xubowenhaoren has tried it out and said that it works well.

I am now looking into dockerizing the development environments (e.g. https://github.com/e-mission/e-mission-docker/pull/5). I'm working on the devapp first. Is there anybody who wants to try it out and give me feedback on the requirements?

shankari commented 4 years ago

In particular, I think that people want to be able to edit the files from a host directory rather than within docker. We can use volumes to map a host directory to a container directory. But should we assume that the user wants to checkout the code directory, or should the container do it for the user? Presumably the user wants to checkout code, switch between branches, etc while developing.

xubowenhaoren commented 4 years ago

Yes, I would love to have the option to configure the branch and other config files outside of the docker.

shankari commented 4 years ago

@xubowenhaoren just to clarify, the goal is to make it easier to use docker to set up development environments, not production environments.

shankari commented 4 years ago

I now have a docker image for the devapp-server. It works in two modes:

@xubowenhaoren @stephhuerre @PatGendre @kafitz @atton16 can you please try it out and see if it works for you and whether the README makes sense? https://github.com/e-mission/e-mission-docker/pull/5

I am going to merge anyway in the next couple of days.

PatGendre commented 4 years ago

Hi @shankari I tested on my PC (not on PWD) the notebook version, and it worked fine :-) The readme is easy to use, just one detail, in the main README there is a sample instruction on how to load data on the server, this instruction would be helpful in the notebook README as well. It is a good idea to update the docker image, thanks!

shankari commented 4 years ago

@PatGendre the notebook container has been around forever. Did you get a chance to test the pending change, which creates containers for the UI?

I was thinking of the notebook README as a supplement to the main README so that we wouldn't copy the information everywhere. If we needed to change it, then if it was in two places, it would need to be changed in two places.

Also, wrt loading data onto the server, wait for my next set of updates :)

PatGendre commented 4 years ago

@shankari Ok thanks, I didn't get your point, now it is clearer.
As for the devapp-serve container, it is definitely interesting, I can install it, but for the moment I've never worked on the UI and didn't even install android studio :-(
I should test this, we should have an opportunity for a new e-mission deployment in the coming weeks, so I would see that with Yann @iciatech-yprime. I'll continue to have a look of the next updates;-)