Unifying label and diary views

e-mission / e-mission-docs

Repository for docs and issues. If you need help, please file an issue here. Public conversations are better for open source projects than private email.

https://e-mission.readthedocs.io/en/latest

BSD 3-Clause "New" or "Revised" License

15 stars 34 forks source link

Unifying label and diary views #740

Closed shankari closed 1 year ago

shankari commented 2 years ago

code for label and diary is in www/js/diary and www/templates/diary
diary view is list.js and list.html
label view is inf_scroll.js and inf_scroll.html

In angular1, the UI is in .html and the javascript controlling the UI is in .js in a type of class called a controller

The functionality in both of them is almost the same. Our goal is to modularize and unify the two so that we have one codebase and the users have one place to go do label trips.

shankari commented 2 years ago

When a user jumps to a date from a year ago, are we allowing them to scroll up and down? I don't believe so, so therefore when they select a date, it just displays that date's trips, correct?

That is not what I assumed. So you are saying that if the user selects a date, they only get to see data for that date? But otherwise, they can scroll up and down?

That does not seem like a great user experience. If we allow people to "infinite scroll", they will assume that they can scroll all the time. I recall you saying that you want to remove the buttons near the calendar date selector because people will just scroll. Without scrolling, we run into all the original issues about knowing which dates actually have data and so on.

shankari commented 1 year ago

Closing this given that we have merged @tyleryandt18's changes and now have a label screen that is fairly close to the diary and opening https://github.com/e-mission/e-mission-docs/issues/902 for the pending changes.