search

e-mission / e-mission-docs

Repository for docs and issues. If you need help, please file an issue here. Public conversations are better for open source projects than private email.
https://e-mission.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
15 stars 34 forks source link

e-mission-docker clean up #791

Open aGuttman opened 2 years ago

aGuttman commented 2 years ago

Remove duplicate files from e-mission-docker repo once the docker changes are added to the server repo

shankari commented 2 years ago

Also, change the examples in the e-mission-docker repo to the new server image.

shankari commented 2 years ago

Also, come up with a mechanism to update the tags in the downstream images automatically.

Concretely, if we push a new release to e-mission-server, the webapp and analysis images and the em-public-dashboard repo need to bump up their numbers and rebuild their own images in a cascading set of rebuilds.

Is this supported by GitHub actions? How does cloud services prefer to deal with it?

shankari commented 2 years ago

Try to merge the differences in the internal emissionlhd repo into the public repo so that we don't have to maintain multiple copies. The changes are not very significant - primarily using jq instead of sed which is not a bad fix to have over the longer term.

shankari commented 2 years ago

Per discussion in https://github.com/e-mission/e-mission-server/pull/875#discussion_r977233118 decide whether we want to reintroduce a simple static file or stay with the existing redirect

Clean up this if check https://github.com/e-mission/e-mission-server/pull/875/files#diff-53eb57ac0b49c269c7061b4c454813b0214d14cfbdd45f6950e9367698891eb4R7 if we decide to stay with the redirect

shankari commented 2 years ago

not sure we need to change bottle live-reload twice https://github.com/e-mission/e-mission-server/pull/875/files#diff-53eb57ac0b49c269c7061b4c454813b0214d14cfbdd45f6950e9367698891eb4R19 and https://github.com/e-mission/e-mission-server/pull/875/files#diff-c503cefcceb302a4a81003be47dd394440a744ff027f7e034c2c99ac65ec6996R29

Although I guess it doesn't hurt

shankari commented 2 years ago

Do we need this given that we only call setup_config while building the image now? https://github.com/e-mission/e-mission-server/pull/875/files#diff-53eb57ac0b49c269c7061b4c454813b0214d14cfbdd45f6950e9367698891eb4R11

shankari commented 2 years ago

Does this need to be fixed?

Screen Shot 2022-09-22 at 12 22 29 PM

It doesn't seem to be very worrying as long as the containers that run the actions are wiped after every run.