e-mission / e-mission-docs

Repository for docs and issues. If you need help, please file an issue here. Public conversations are better for open source projects than private email.
https://e-mission.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
15 stars 34 forks source link

🚸 Double-checking what happens while transferring the app to another phone #928

Open shankari opened 1 year ago

shankari commented 1 year ago

Got a new phone Restored backup, including all apps Launched OpenPATH

Note that while setting up DavX, there is an option to turn on regular sync intervals. "For synchronization at regular intervals, DavX must be allowed to run in the background. Otherwise, Android may pause synchronization at any time".

Turning it on doesn't actually require whitelisting anything - there's just a simple "Allow" button. Should check their source code to see what it does.

They also have a page with more information on disabling sync for OnePlus. Let's see how they choose to recommend things to us...

shankari commented 1 year ago

Hm, per the code, it should be generating nrelopenpath:// Need to double check that as well...

        $scope.tokenURL = "nrelopenpath://login_token?token="+$scope.settings.auth.opcode;
shankari commented 1 year ago

For the record, when my Google Maps was transferred over, the "incognito" mode was removed. I was in incognito mode on the original phone (double checked) but I was signed in with my google account on my new phone. Sneaky!

shankari commented 1 year ago

I spent some time investigating this https://github.com/e-mission/e-mission-docs/issues/928#issuecomment-1606732961, including by installing a QR code app. I can confirm that on version 1.3.3 (both my phone and @mRaffill's phone), the QR code encodes emission://. However, I changed it from emission:// to nrelopenpath:// in

commit 4405342b312e043b4f6cf19a73a0d366ed5eaa40
Merge: 69b7207c 78368acd
Author: K. Shankari <k.shankari@nrel.gov>
Date:   Fri Apr 21 22:19:11 2023 -0700

    Merge branch 'master_for_platform' of https://github.com/e-mission/e-mission-phone into nrel_openpath

    All changes were due to the package/app name change:
    - config.xml and package.json had different versions and package name
        - picked the openpath version
    - general-settings had the opcode save as emission:// instead of nrelopenpath://
        - picked the openpath version, but changed to saving `opcode` instead of `email`

diff --cc www/js/control/general-settings.js
index ce9823a5,e8e6b71d..16f7e3b0
--- a/www/js/control/general-settings.js
+++ b/www/js/control/general-settings.js
@@@ -99,7 -96,7 +96,7 @@@ angular.module('emission.main.control',
      }

      $scope.viewQRCode = function($event) {
-         $scope.tokenURL = "nrelopenpath://login_token?token="+$scope.settings.auth.email;
 -        $scope.tokenURL = "emission://login_token?token="+$scope.settings.auth.opcode;
++        $scope.tokenURL = "nrelopenpath://login_token?token="+$scope.settings.auth.opcode;
          if ($scope.qrp) {
              $scope.qrp.show($event);
          } else {

And the current release is from Jun 22, so it should be correct.

    $scope.viewQRCode = function($event) {
        $scope.tokenURL = "nrelopenpath://login_token?token="+$scope.settings.auth.opcode;

I tried killing and restarting, just in case there was some old popup being displayed somewhere, but it still showed up with the emission prefix. The newer, beta version does show nrelopenpath correctly, so I am going to drop this for now, but we should re-check after merging @Abby-Wheelis' control screen changes.