search

e-mission / e-mission-eval-private-data

Evaluate the e-mission platform along various metrics
BSD 3-Clause "New" or "Revised" License
1 stars 11 forks source link

plot graphs for all users #15

Closed corinne-hcr closed 3 years ago

corinne-hcr commented 3 years ago

Fixed graph(). Now it should finish subplotting and then return the figure. So, it can plot graph for all users. image

shankari commented 3 years ago

Please clear all outputs from the notebook before submitting so that:

Please see this note in the README https://github.com/e-mission/e-mission-eval-private-data#checking-in-notebooks

corinne-hcr commented 3 years ago

updated the PR

shankari commented 3 years ago

@corinne-hcr can you please mark this as ready for review so I can merge it?

This pull request is still a work in progress
Draft pull requests cannot be merged.
shankari commented 3 years ago

Also, I plan to squash and merge so we get a clean commit. https://blog.dnsimple.com/2019/01/two-years-of-squash-merge/

make sure to pull appropriately.