e-mission / em-public-dashboard

A simple and stupid public dashboard prototype.
BSD 3-Clause "New" or "Revised" License
1 stars 23 forks source link

Charts are not generated for Average Trips Length (selected by users) and Average Trip Length (sensed) metrics #107

Open iantei opened 9 months ago

iantei commented 9 months ago

Both Average Trips Length (selected by users) and Average Trip Length (sensed) are not generated in the production environment for public dashboard associated with https://ebikegj-openpath.nrel.gov/public/ Also, replicable in below: https://openpath-stage.nrel.gov/public/

image

The above two metrics i.e. "Average Trips Length (selected by users)" and "Average trip length (sensed)" are represented by average_miles_mode_confirm2 and average_miles_sensed_mode respectively in metrics_study/program.html. All other metrics generated are associated with their respective values in notebook to generate static charts. With both of these metrics, there are no associated code available in notebook to generate the required static charts.

Investigation details:

  1. For Average Trip Length (selected by users):

The generation of chart associated with "Average Trip Length (selected by users)" have been removed in the commit https://github.com/e-mission/em-public-dashboard/pull/51 . Further, I do not see any file_name associated with average_miles_mode_confirm2 in the current main branch.

image

Possible solution: There's barplot_mode2() present on plots.py. We could revert back this change, and make call for this function from generic_metrics.ipynb notebook and it should work.

  1. For Average Trip Length (sensed):

There are no required changes which would generate the file average_miles_sensed_mode in generic_metrics_sensed.ipynb notebook, while all other sensed related metric chart files are being generated properly here. https://github.com/e-mission/em-public-dashboard/pull/92

Possible solution: We will need to incorporate changes for the average_miles_sensed_mode in the generic_metrics_sensed.ipynb.