Open iantei opened 4 weeks ago
Test Scenario:
Program: cortezebikes
Both generic_metrics
and mode_specific_metrics
notebook ran successfully, and the results look good.
```
(emission) root@c5aa29285331:/usr/src/app/saved-notebooks# PYTHONPATH=.. python bin/update_mappings.py mapping_dictionaries.ipynb
(emission) root@c5aa29285331:/usr/src/app/saved-notebooks# PYTHONPATH=.. python bin/generate_plots.py generic_metrics.ipynb default
/usr/src/app/saved-notebooks/bin/generate_plots.py:30: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if r.status_code is not 200:
About to download config from https://raw.githubusercontent.com/e-mission/nrel-openpath-deploy-configs/main/configs/cortezebikes.nrel-op.json
Successfully downloaded config with version 1 for Cortez 55+ eBike Program and data collection URL https://cortezebikes-openpath.nrel.gov/api/
label_options is unavailable for the dynamic_config in cortezebikes
Running at 2024-08-19T23:52:08.740014+00:00 with args Namespace(plot_notebook='generic_metrics.ipynb', program='default', date=None) for range (
Results: | Charts Type | Charts |
---|---|---|
All Stacked Bar Charts | ||
Number of Trips with Table |
The charts look great! I'll look at the code next, but I do have one quick question - could a given trip be in the sensed, inferred, and labeled charts? Some of these look like labeled & inferred add to about 100%, but that is probably coincidence
The charts look great! I'll look at the code next, but I do have one quick question - could a given trip be in the sensed, inferred, and labeled charts? Some of these look like labeled & inferred add to about 100%, but that is probably coincidence
We can label a trip detected as certain mode of commute to be the same or different as the one detected. I am not sure about how labeled & inferred add up to 100.
I can take a look at the code, but some high level comments just by looking at the charts first:
I also took a brief look at the code, and I think that the current inferred_labels
is only inferred labels. So if a trip had both inferred and user labels, we would use only the inferred labels even if they were wrong. That seems wrong and is certainly going to be confusing to users. The inferred labels bar should actually be "labeled and inferred" and we should only use the inferred labels for trips where they exist, but there is no user label
A. Introduce processing functionalities in scaffolding.py for inferred labels.