search

e-mission / nrel-openpath-deploy-configs

Configurations for current OpenPATH deployments, published for transparency
BSD 3-Clause "New" or "Revised" License
2 stars 9 forks source link

Spanish Version of why_we_collect in .config files #11

Closed sebastiandsc closed 1 year ago

sebastiandsc commented 1 year ago

In the join page when making the change from English to Spanish the property (key) called "why_we_collect" in the Spanish version appears as "why_we_collect_es", generating a problem because when making the dynamic change of the text of the web page does not find this key ("why_we_collect") in the JSON file when the fetch is done. Therefore, we have decided to create this property in the key "ES" in each of the JSON files of the studies.

shankari commented 1 year ago

@dcolondavila can you please file the issue so that I can merge this?

dcolondavila commented 1 year ago

Will do. It will be filed at e-mission-docs.

shankari commented 1 year ago

@dcolondavila once it is filed, I can merge this.

dcolondavila commented 1 year ago

Done ✔️

shankari commented 1 year ago

New issue is https://github.com/e-mission/e-mission-docs/issues/844

shankari commented 1 year ago

Merged. Please see the additional comment in the issue.