search

e-mission / nrel-openpath-deploy-configs

Configurations for current OpenPATH deployments, published for transparency
BSD 3-Clause "New" or "Revised" License
2 stars 9 forks source link

Files for UCD, NCCC, and Laos #24

Closed Abby-Wheelis closed 1 year ago

Abby-Wheelis commented 1 year ago

Based on agreements and other recent examples, developing configuration files for three more deployments

Abby-Wheelis commented 1 year ago

File names are now: ca-ebike usaid-laos-ev fortmorgan

Abby-Wheelis commented 1 year ago

I've now checked on all the pages (3x2 supported languages) and all the phoneapps -- there is an issue with the Lao on the phone, even with the phone in Lao it is just showing English. Also, on the join page for the Lao, the parts specified by the config are translated but not the rest (which I'm guessing is a characteristic of the continued move to i18n and getting translations from people)

All in all, looking good to me with the exception of the Lao that still has issued to work out

shankari commented 1 year ago

I've now checked on all the pages (3x2 supported languages) and all the phoneapps -- there is an issue with the Lao on the phone, even with the phone in Lao it is just showing English.

To get this to work on the phone app, you also need to change the set of languages to include lo https://github.com/e-mission/e-mission-phone/blob/4a21c61f121bbf7e55a7b59c0ed82a270c6e6706/www/js/app.js#L113

and also change the translate config to pull from master_for_platform (I currently do this by switching to master_for_platform in locales

locales $ git checkout --track origin/master_for_platform

So all subsequent pulls in hooks/before_prepare/download_translation.js will pull from the correct branch

Alternatively, you can wait until I merge these changes and then try using the OpenPATH app on a real phone (The OpenPATH app is already configured as above)

Also, on the join page for the Lao, the parts specified by the config are translated but not the rest (which I'm guessing is a characteristic of the continued move to i18n and getting translations from people)

Exactly. See the two files that I sent to Kosol for translation on June 9 (and followed up today). The join_page_template.docx is essentially the template parts of the join page

Abby-Wheelis commented 1 year ago

I was able to make the changes you mentioned and things showed up as expected! Still a mix for now in some places, but confirmed to work. Screenshot of a page with the Lao!