search

e-mission / nrel-openpath-deploy-configs

Configurations for current OpenPATH deployments, published for transparency
BSD 3-Clause "New" or "Revised" License
2 stars 9 forks source link

Add mode of interest to configs #4

Closed zackAemmer closed 1 year ago

zackAemmer commented 1 year ago

For each config, if it corresponds to a program then add the mode of interest as a parameter in the config file. This is used when running the program-specific visualization notebooks. For now, all of the programs are interested in ebikes, though this may change in future programs. For the testing configs, I also made the mode of interest ebike.

zackAemmer commented 1 year ago

Committed all suggested changes. Only thing I would clarify is that the "mode_studied" variable is used directly in the program-notebooks to filter. If previous data collected still has "pilot_ebike" labels then it will be removed from the plots. I see that not all the configs were changed to e-bike, so I am assuming that the ones which were changed will only use "e-bike"!

shankari commented 1 year ago

@zackAemmer the intent was to change everything to e-bike. All OpenPATH deployments use only e-bike. Only the old CanBikeCO deployments (hosted outside of NREL) use pilot_ebike. We can fix that using backwards compat, added to https://github.com/e-mission/e-mission-docs/issues/788 to track in case we need it.

Can you let me know which configs have not been changed? I don't see any!

zackAemmer commented 1 year ago

@zackAemmer the intent was to change everything to e-bike. All OpenPATH deployments use only e-bike. Only the old CanBikeCO deployments (hosted outside of NREL) use pilot_ebike. We can fix that using backwards compat, added to e-mission/e-mission-docs#788 to track in case we need it.

Can you let me know which configs have not been changed? I don't see any!

I was thinking that there were more because not all of the configs were changed, but of course the remainder are studies and not programs. My mistake.