e-mission / nrel-openpath-deploy-configs

Configurations for current OpenPATH deployments, published for transparency
BSD 3-Clause "New" or "Revised" License
2 stars 9 forks source link

manually added the Key-Value pair ("data_trajectories_columns_exclude": ["user_id"]) to JSONs wherever admin_dashboard is present #41

Closed niccolopaganini closed 9 months ago

niccolopaganini commented 9 months ago
  1. Manually added "data_trajectories_columns_exclude": ["user_id"] to JSON files which contain the admin_dashboard key.
  2. Ignored JSON files
    • "ca-ebike.nrel-op.json"
    • "stage-program.nrel-op.json"
    • "stage-study.nrel-op.json"
    • "uprm-civic.nrel-op.json"
    • "uprm-nicr.nrel-op.json"
    • "usaid-laos-ev.nrel-op.json"
    • "uue.nrel-op.json"
    • "washingtoncommons.nrel-op.json"
niccolopaganini commented 9 months ago

Tagging @shankari due to time sensitivity. Please let me know if this is wrong and I won't repeat the same in the future

niccolopaganini commented 9 months ago

Does it look good now @shankari? (tagging again due to time sensitivity)

shankari commented 9 months ago

@niccolopaganini I am not sure if all the files are converted correctly

$ ls -1 configs | wc -l
      28

$ ls -1 configs | egrep -v "ca-ebike|stage-program|stage-study|uprm-civic|uprm-nicr|usaid-laos-ev|uue|washingtoncommons" | wc -l
      20

But there are only 17 modified files here

Screenshot 2023-10-06 at 10 23 13 PM

The full list of files which should be modified is

$ ls -1 configs | egrep -v "ca-ebike|stage-program|stage-study|uprm-civic|uprm-nicr|usaid-laos-ev|uue|washingtoncommons"
caeb-co.nrel-op.json
ccebikes.nrel-op.json
choose-your-ride.nrel-op.json
cortezebikes.nrel-op.json
denver-casr.nrel-op.json
dev-emulator-program.nrel-op.json
dev-emulator-study.nrel-op.json
dev-emulator-timeuse.nrel-op.json
durham.nrel-op.json
e-bikes-for-essentials.nrel-op.json
ebikegj.nrel-op.json
ebikethere-garfield-county.nrel-op.json
fortmorgan.nrel-op.json
mm-masscec.nrel-op.json
nrel-commute.nrel-op.json
open-access.nrel-op.json
ride2own.nrel-op.json
smart-commute-ebike.nrel-op.json
stage-timeuse.nrel-op.json
wyoming.nrel-op.json

@niccolopaganini can you please check which ones are missing and add them?

niccolopaganini commented 9 months ago

I reverted it back to the original format and made sure any manual entries on that file (from my end) is absent.

niccolopaganini commented 9 months ago

Tagging @shankari for time sensitivity

niccolopaganini commented 9 months ago

@niccolopaganini I am not sure if all the files are converted correctly

$ ls -1 configs | wc -l
      28

$ ls -1 configs | egrep -v "ca-ebike|stage-program|stage-study|uprm-civic|uprm-nicr|usaid-laos-ev|uue|washingtoncommons" | wc -l
      20

But there are only 17 modified files here

Screenshot 2023-10-06 at 10 23 13 PM

The full list of files which should be modified is

$ ls -1 configs | egrep -v "ca-ebike|stage-program|stage-study|uprm-civic|uprm-nicr|usaid-laos-ev|uue|washingtoncommons"
caeb-co.nrel-op.json
ccebikes.nrel-op.json
choose-your-ride.nrel-op.json
cortezebikes.nrel-op.json
denver-casr.nrel-op.json
dev-emulator-program.nrel-op.json
dev-emulator-study.nrel-op.json
dev-emulator-timeuse.nrel-op.json
durham.nrel-op.json
e-bikes-for-essentials.nrel-op.json
ebikegj.nrel-op.json
ebikethere-garfield-county.nrel-op.json
fortmorgan.nrel-op.json
mm-masscec.nrel-op.json
nrel-commute.nrel-op.json
open-access.nrel-op.json
ride2own.nrel-op.json
smart-commute-ebike.nrel-op.json
stage-timeuse.nrel-op.json
wyoming.nrel-op.json

@niccolopaganini can you please check which ones are missing and add them?

The 3 files are:

  1. dev-emulator-program.nrel-op.json
  2. dev-emulator-study.nrel-op.json
  3. dev-emulator-timeuse.nrel-op.json

I did not add the kv-pair because there was no admin_dashboard key. dev-emulator-program.nrel-op.json for reference:

{
    "version": 1,
    "ts": 1655143472,
    "intro": {
        "program_or_study": "program",
        "start_month": "9",
        "start_year": "2020",
        "mode_studied": "e-bike",
        "program_admin_contact": "K. Shankari (k.shankari@nrel.gov)",
        "deployment_partner_name": "National Renewable Energy Laboratory (NREL)",
        "translated_text": {
            "en": {
                "deployment_partner_name": "National Renewable Energy Laboratory (NREL)",
                "deployment_name": "Development environment (program)",
                "summary_line_1": "allows developers to work on the OpenPATH app",
                "summary_line_2": "connect to a local server",
                "summary_line_3": "and ensure that end-to-end program features work.",
                "short_textual_description": "OpenPATH is the only open source platform for instrumenting mobility patterns. We welcome contributions and pull requests.",
                "why_we_collect": "So that you can see how OpenPATH works",
                "research_questions": ["Comparing the open-access group (no intervention) and programs that provide interventions.", "General monitoring of mobility trends for travel behavior, including shifts to travel behavior and the introduction of new mobility modes."]
            },
            "es":{
                "deployment_partner_name": "Laboratorio Nacional de Energías Renovables (NREL)"
            }
        }
    },
    "label_options": "https://raw.githubusercontent.com/e-mission/nrel-openpath-deploy-configs/main/label_options/example-program-label-options.json",
    "display_config": {
        "use_imperial": false
    },
    "profile_controls": {
        "support_upload": true,
        "trip_end_notification": true
    }
}
shankari commented 9 months ago

Congratulations on your first merged PR!