e-mission / nrel-openpath-deploy-configs

Configurations for current OpenPATH deployments, published for transparency
BSD 3-Clause "New" or "Revised" License
2 stars 9 forks source link

CA e-bike incentives project revised labels json file #42

Closed si-agarwal closed 8 months ago

si-agarwal commented 8 months ago

Translation of some of the labels to Spanish is remaining

shankari commented 8 months ago

@Abby-Wheelis can you check on the baseModes here and see if they are valid (and potentially correct them if they are not)? We don't have any documentation on where they come from and I think that @si-agarwal may not have checked to make sure that they exist in the phone code.

shankari commented 8 months ago

Also changed the config file to use these labels in https://github.com/e-mission/nrel-openpath-deploy-configs/commit/041ec7bf46fcfdf521b0a4519f1292ef69a8ead3

@Abby-Wheelis since this is the first real custom label deployment, if you have time, could you test it and make sure that it works properly before the CA E-bike meeting tomorrow.

@si-agarwal you can also try it out - just uninstall the app and reinstall with:

You should then see the new labels. Please let us know if you encounter any issues.

Abby-Wheelis commented 8 months ago

I've tested it out, and the new labels are showing up! Two small notes:

  1. some of the longer purpose labels are wider than the app screen, and don't loop
  2. in Spanish, the missing labels are showing up as the keys, I would recommend adding the translations
Modes Purposes
Screenshot 2023-11-07 at 5 46 41 PM Screenshot 2023-11-07 at 5 46 58 PM
Screenshot 2023-11-07 at 5 44 16 PM Screenshot 2023-11-07 at 5 44 24 PM