Closed Abby-Wheelis closed 7 months ago
ensuring the LISENCE is correct
The repo that I based the issue -> JSON converted on does not have a license, at least at this moment, so my plan is to make sure that I link to the files I was adapting to make sure credit is still provided.
In d39aa9a and b3e217f I copied the file from @sebastianbarry's repo into this PR, and updated the link to reflect where that sample file will rest in the e-mission
repo once this is merged.
The thing I don't have is the xml
or xls
files for that survey, which might be easier to read if someone was trying to reference them. @sebastianbarry (and maybe @JGreenlee who also had commits in the repo where I found the survey), do either of you happen to still have either of those original files? Maybe they had a different name in the repo but I couldn't find them.
As far as I know, the xml
and xls
have been missing the whole time. I think that survey was created by external partners – it may be that they only provided it to us in JSON format because the others aren't required for it to work.
There's some chance @asiripanich would have the original XML or Excel files for the trip-end-survey? It was many months ago so it's understandable if not.
@AlirezaRa94 is
There's some chance @asiripanich would have the original XML or Excel files for the trip-end-survey? It was many months ago so it's understandable if not.
@AlirezaRa94, can you please help @JGreenlee with this? I think it can be easily exported from our Enketo account.
@asiripanich @JGreenlee Is this the file that you are looking for? trip-confirm-survey-form.zip
@AlirezaRa94 yes, that matches the JSON file that we have, thank you! If you happen to also have the xlsx file that would be great, but if not no worries!
I think this is ready for review, unless we want to wait for more changes, but it includes:
Which covers the main goals of this PR. If we later find the xls
file for the survey, come up with a better way to handle language, or receive feedback for changes needed from the review and/or testing process that can probably be in a new PR
Some examples of what the new field looks like once the issue has been created, and in the issue form.
Better than before, needs some check/follow-up on the LICENSE
Changes to polish the config automation including:
/configs
filese-mission
(currently in @sebastianbarry's repo)(tasks from review of #46)