search

e-mission / nrel-openpath-deploy-configs

Configurations for current OpenPATH deployments, published for transparency
BSD 3-Clause "New" or "Revised" License
2 stars 9 forks source link

🚫 Fix "connectURL" bug in GitHub Action - Correct "connectURL" key to "connectUrl" #74

Closed sebastianbarry closed 4 months ago

sebastianbarry commented 4 months ago

The problem that we experienced with the github workflow when @shankari and Jianli found when testing doee-electricbike-proj was that the field connectURL had capitalized URL, when it's supposed to be read into e-mission-phone as connectUrl. This minor change fixes that problem!

Thanks to @Abby-Wheelis for the help in understanding github workflows!

Testing: See my test GitHub workflow automated issue (tested in my forked repo) https://github.com/sebastianbarry/nrel-openpath-deploy-configs/issues/2 (Actual result of the change in: https://github.com/sebastianbarry/nrel-openpath-deploy-configs/commit/a4fbfc06ec867d4aaebb5a719748355534a57590)

sebastianbarry commented 4 months ago

This is fine, but maybe you can also roll in the opcode changes as a separate commit?

@shankari Could you remind me what do you mean by the opcode changes?

shankari commented 4 months ago

https://github.com/e-mission/e-mission-docs/issues/1050#issuecomment-1938071989