Open sebastianbarry opened 1 year ago
@shankari and @JGreenlee
Adding you both for visibility
Here are the generated QR codes if you would rather just scan them/copy paste them from here:
Devapp Study Tripconfirm | emission://join_study?label=dev-emulator-study-tripconfirm&source=github |
---|---|
Devapp Program Tripconfirm | emission://join_study?label=dev-emulator-program-tripconfirm&source=github |
@sebastianbarry wrt https://github.com/e-mission/nrel-openpath-deploy-configs/pull/8/commits/bacd4ffc826ad55af2da28d4fc15cbed7fdffadf, did you and @JGreenlee decide to go with the simple but verbose version since it is already implemented?
I am fine with that decision, and I'm glad to see that we are focusing on getting the code to work, but just want to understand the reasons.
@shankari @sebastianbarry Yes, given our time constraints we are trying to just get it working, so we decided to roll back to the more verbose version at least for now. We can revisit the dynamic surveys.json later if necessary - but we would need to write the logic to load in the surveys.json file by URL and would want your input before we made those decisions
ONLY WORKS FOR DEV_PROGRAM AND DEV_STUDY, to incorporate this into the existing studies/programs we will need to add the
survey_info.buttons
fields for all the others as wellThis is the new refactored format for the dynamic configs that contains:
configs/surveys/surveys.json
survey_info
field in the configs json for dev-emulator-program and dev-emulator-studyBecause this is a new PR, let's close the original dynamic surveys pr https://github.com/e-mission/nrel-openpath-deploy-configs/pull/7 because it is old, not exactly what we want, and has some problems in terms of incorrect commits and confusion