search

e-mission / nrel-openpath-deploy-configs

Configurations for current OpenPATH deployments, published for transparency
BSD 3-Clause "New" or "Revised" License
2 stars 9 forks source link

-Updated .config files #9

Closed dcolondavila closed 1 year ago

dcolondavila commented 1 year ago

We have updated all the .config files and added "deployment_partner_name" in English and Spanish. We did no modifications to the original structure of the code. We also noticed that dev-emulator-program.json, dev-emulator-study.json and nrel-commute.json files don't have a Spanish version, so we added one.

dcolondavila commented 1 year ago

Once everything has been evaluated and merged, we will do another PR at the Join Page repo with a new updated code. And we will also upload a demo video.

shankari commented 1 year ago

We also noticed that dev-emulator-program.json, dev-emulator-study.json and nrel-commute.json files don't have a Spanish version, so we added one.

For the record, the nrel-commute.json is for NREL employees and we don't (didn't) anticipate having a lot of employees whose phone language is set to Spanish. Similarly the dev-*.json configs are for developers to work with the app, and again, so far, all our primary developers are native English speakers.

Thank you for adding the translations, though. It will help open up the development community to Spanish speakers as well. Maybe if you have time and it is easy for you to do (you don't need to use Google Translate), you could also specify the translations for the other translated text in these configs as well.

shankari commented 1 year ago

@dcolondavila this is now merged, you can make the join changes and upload the new video