search

e-mission / op-admin-dashboard

An admin/deployer dashboard for the NREL OpenPATH platform
0 stars 9 forks source link

Timeseries query #34

Closed AlirezaRa94 closed 1 year ago

AlirezaRa94 commented 1 year ago

Using time series queries to address https://github.com/e-mission/op-admin-dashboard/issues/29

shankari commented 1 year ago

I don't see any high level issues, and am happy to merge this once you have verified that it works (aka indicated testing done)

AlirezaRa94 commented 1 year ago

I don't see any high level issues, and am happy to merge this once you have verified that it works (aka indicated testing done)

I have tested the dashboard with the development docker-compose on both types of authentication and didn't see any errors on different pages.

shankari commented 1 year ago

@AlirezaRa94 have you tested it with the use case of invalid columns? e.g. what if the user specifies a column that doesn't exist in the data? This can happen due to misconfiguration, or even for properly configured systems, before the users have entered any labels

AlirezaRa94 commented 1 year ago

@AlirezaRa94 have you tested it with the use case of invalid columns? e.g. what if the user specifies a column that doesn't exist in the data? This can happen due to misconfiguration, or even for properly configured systems, before the users have entered any labels

Yes, It works in these scenarios, and I have tried to consider them.