Closed achasmita closed 1 year ago
@achasmita
Code looks fine. Please indicate "Testing done" before I can merge. "If it is not tested, it is broken"
Yes, testing is done and table looks fine.
@achasmita thank you for including the screenshot. Please do that for all PRs going forward.
However, the testing is not sufficient because it doesn't actually show any of the demographic survey fields. How do I know if the demographic survey is actually being parsed properly?
Also, please automatically exclude the vast majority of the metadata fields. We don't need the metadata.key
(which is the same for all entries, or the metadata.type
, ...
Please updated with more descriptive screenshots that show what you are actually testing.
@achasmita thank you for including the screenshot. Please do that for all PRs going forward.
However, the testing is not sufficient because it doesn't actually show any of the demographic survey fields. How do I know if the demographic survey is actually being parsed properly?
Also, please automatically exclude the vast majority of the metadata fields. We don't need the
metadata.key
(which is the same for all entries, or themetadata.type
, ...Please updated with more descriptive screenshots that show what you are actually testing.
Here is the one after removing metadata.key and including demographic survey fields.
Does this only remove metadata.key
? Please note my comment
Also, please automatically exclude the vast majority of the metadata fields.
You can, and should, include multiple screenshots to showcase the breadth of your testing.
Does this only remove
metadata.key
? Please note my commentAlso, please automatically exclude the vast majority of the metadata fields.
i mean all the columns that starts with metadata.
Here is the screenshot of all the columns it is displaying now:
Please push these changes and I can merge
new screenshots
@achasmita
Code looks fine. Please indicate "Testing done" before I can merge. "If it is not tested, it is broken"