search

e-mission / op-admin-dashboard

An admin/deployer dashboard for the NREL OpenPATH platform
0 stars 10 forks source link

Removing extraneous columns from demographic table #67

Closed achasmita closed 1 year ago

shankari commented 1 year ago

@achasmita

  1. please indicate testing done. "If it is not tested, it is broken"
  2. From a clean commit history perspective, the second commit message is a duplicate of the first and is incorrect
  3. how come these didn't show up in the testing of the previous PR (#63)? Are these columns not in the test dataset that has been shared with you?
achasmita commented 1 year ago

@achasmita

  1. please indicate testing done. "If it is not tested, it is broken"
  2. From a clean commit history perspective, the second commit message is a duplicate of the first and is incorrect
  3. how come these didn't show up in the testing of the previous PR (Updated readme and added demographics table #63)? Are these columns not in the test dataset that has been shared with you?

No, those columns are not available in the dataset provided to me. So it was all good when I tested locally. But I saw extraneous columns while in staging.

shankari commented 1 year ago

Merging this now to try and resolve showstopper https://github.com/e-mission/op-admin-dashboard/issues/65

shankari commented 1 year ago

@achasmita I am squash-merging this, please take it into account while pulling from upstream.