e-mission / op-admin-dashboard

An admin/deployer dashboard for the NREL OpenPATH platform
0 stars 8 forks source link

Used find_entries_count() function to count database entries. #69

Closed achasmita closed 10 months ago

shankari commented 10 months ago

@achasmita I am not going to hold up merging this change for this, but in general, when you are working on two tasks in parallel, you want to have two separate branches from master. As you can see, if you don't do that, all the commits from the previous PR also show up in this PR, which makes it hard to review them independently.

shankari commented 10 months ago

@achasmita I rebased the PR a couple of times, we now see only the new commit. Please indicate "testing done" it would be better to actually make sure to indicate testing done for each commit

achasmita commented 10 months ago

@achasmita I rebased the PR a couple of times, we now see only the new commit. Please indicate "testing done" it would be better to actually make sure to indicate testing done for each commit

I will make sure from next time. Yes, it is working fine.

shankari commented 10 months ago

@achasmita screenshots plz

achasmita commented 10 months ago

@achasmita screenshots plz

I don't have UUID table so the count for active user is 0 both before and after the test while confirmed trip is 6829 both before and after the test.

achasmita commented 10 months ago

Screen Shot 2023-09-27 at 4 59 40 PM

shankari commented 10 months ago

@achasmita is this before or after? I would like to see

Before screenshot

...

After screenshot

...

achasmita commented 10 months ago

The screenshot is same for both before and after.

shankari commented 10 months ago

Right, so you should say that, or put two (visually identical) screenshots for before and after to show that they are the same

achasmita commented 10 months ago

ok here is the one before: Screen Shot 2023-09-27 at 4 59 40 PM

And after changes

Screen Shot 2023-09-27 at 5 11 46 PM

shankari commented 10 months ago

I do note that the timestamps on them are different, indicating that you took them at different times 😄