Closed achasmita closed 10 months ago
@achasmita I rebased the PR a couple of times, we now see only the new commit. Please indicate "testing done" it would be better to actually make sure to indicate testing done for each commit
@achasmita I rebased the PR a couple of times, we now see only the new commit. Please indicate "testing done" it would be better to actually make sure to indicate testing done for each commit
I will make sure from next time. Yes, it is working fine.
@achasmita screenshots plz
@achasmita screenshots plz
I don't have UUID table so the count for active user is 0 both before and after the test while confirmed trip is 6829 both before and after the test.
@achasmita is this before or after? I would like to see
...
...
The screenshot is same for both before and after.
Right, so you should say that, or put two (visually identical) screenshots for before and after to show that they are the same
ok here is the one before:
And after changes
I do note that the timestamps on them are different, indicating that you took them at different times 😄
@achasmita I am not going to hold up merging this change for this, but in general, when you are working on two tasks in parallel, you want to have two separate branches from
master
. As you can see, if you don't do that, all the commits from the previous PR also show up in this PR, which makes it hard to review them independently.