e-mission / op-admin-dashboard

An admin/deployer dashboard for the NREL OpenPATH platform
0 stars 8 forks source link

Trajectory table is not getting filtered by date range. #72

Closed achasmita closed 10 months ago

achasmita commented 10 months ago

I tried same method used in trip table and passed start_date and end_date as an input but the filter did not work. I also tried creating separate callback for trajectory table in data page that also did not work. It is reading the data but there is no change in table as expected. Screen Shot 2023-09-29 at 3 21 50 PM

shankari commented 10 months ago

@achasmita lets continue discussing this in the issue. What do you mean by "the filter did not work" other than the amount of data loaded.

What did you do to debug the filter and to see if the values were passed through correctly?

achasmita commented 10 months ago

ok I was doing wrong while passing date , I reverted and tried it again and it works now both way.

shankari commented 10 months ago

Can you update the PR with only the date passing fix? I can then merge and deploy and then review the scalability change for the next release train.

shankari commented 10 months ago

Can you also record in here how you were passing the date before and what the correct way to pass it is? Again, will help with context for the future, including for you!

achasmita commented 10 months ago

df = query_trajectories(start_date_obj,end_date_obj) I was passing None everytime here while querying data instead of date range selected by user.

shankari commented 10 months ago

Fixed by https://github.com/e-mission/op-admin-dashboard/pull/71