Closed achasmita closed 5 months ago
Here I have grouped data by mode, so that data is plotted based on selected modes:
Bubble map:
Before:
After mode filter is added:
![]()
Density Heatmap:
Before:
After mode filter is added:
Trip Lines map:
With the new changes
We can now filter bubble and density heat map by different modes (there were no filters in this two maps before). And for trip map as there was already a filter option with UUID's and emails:
now it can be either filtered by mode or by UUID's and emails
@achasmita
Please see my comment above:
I checked to see if the commits had more information, but each commit only has a single line "added mode specific filter for maps "
I still only see one line for this comment "cleaned and made changes in previous code" I expect to see an actual description of the changes, similar to https://github.com/e-mission/em-public-dashboard/pull/112/commits/68911815a6b3168f9c48fcd0169f2e64fb0d17be
Please confirm that you have seen this message and will implement it going forward
@achasmita
Please see my comment above:
I checked to see if the commits had more information, but each commit only has a single line "added mode specific filter for maps "
I still only see one line for this comment "cleaned and made changes in previous code" I expect to see an actual description of the changes, similar to e-mission/em-public-dashboard@6891181
Please confirm that you have seen this message and will implement it going forward
I will make sure to follow it going forward
Pending feedback from @JGreenlee and potential removal of the scatterplot in the heatmap.
@achasmita please add testing done after the last set of changes
Scatter plot is removed from heatmap and testing is done.
I started grouping data by confirmed modes and used that data to filter all three maps:
![Screen Shot 2023-12-11 at 11 27 53 AM](https://github.com/e-mission/op-admin-dashboard/assets/79387860/6cb3d6b6-aa3b-4afa-bfe4-a60ce25e775b) ![Screen Shot 2023-12-11 at 11 28 23 AM](https://github.com/e-mission/op-admin-dashboard/assets/79387860/08cc110c-8595-46c3-83b2-ee3389c96e45) ![Screen Shot 2023-12-11 at 11 29 22 AM](https://github.com/e-mission/op-admin-dashboard/assets/79387860/30893b16-f6a9-4c32-ab5a-6c8f77741db6)