search

e-money / em-ledger

BFT distributed ledger for e-Money.com
https://e-money.com
Apache License 2.0
41 stars 17 forks source link

Only pay for used gas #8

Open mdyring opened 4 years ago

mdyring commented 4 years ago

Users should only pay for gas consumed on a transaction, not the maximum allowance.

This is to prevent "fat finger" incidents (as seen on Cosmos Hub) and for fairness.

This seems in line with what IRISnet is doing: https://github.com/irisnet/irishub/blob/fdc78914a514ead0fc62d4773dcbae1a31b66fac/app/v1/auth/feeauth.go#L63

blewater commented 3 years ago

These SDK developments are relevant https://github.com/e-money/em-ledger/issues/51#issuecomment-854807530 and we need to consider that the transaction parameter GasWanted (--gas) is equivalent to GasLimit in Ethereum and functions correctly in the SDK. Sure fees are taken in whole and that's a feature just like in Ethereum, BTC and even more relevant once the Cosmos SDK introduces prioritization https://github.com/cosmos/cosmos-sdk/discussions/9348 In any case, once the SDK introduces centralized fee management (per message ideally) https://github.com/cosmos/cosmos-sdk/discussions/9072 or we offer that along with the aforementioned Refund middleware we could address this issue.