Closed costin closed 13 years ago
Turning off pooling seems to solve 1" (the CCE problems)
P. S. Seems to be a problem with Github comments since my edits do not show up
Looks like I have reproduced second problem and I will look into it. If subscribe use the same thread for message listening it will block that thread. I'm not sure that client will expect that behavior.
Actually if you're coming from a Redis background, that's what you expect. Also other libraries (like Jedis) use the same approach. At the end of the day, both approaches (simple but blocking and non-blocking with an additional thread) could be offered.
Looks like you right... Ok, I'll simplify pubsub functionality and remove threading stuff.
RedisNodeSubscriber was completely reworked and simplified. Update is available in integration branch and will be available in 0.6.3 release
Great - any ETA for 0.6.3? For us, the sooner the better since I'd like the next release of Spring Data to feature RJC as well.
If it is critical for you I can release next version on Monday or Tuesday evening, maybe with some minor fixes. Is it Ok for you?
That would be great! Thanks!
Since Redis subscriptions are blocking, currently rjc creates a thread that waits for messages to arrive. However this has several issues:
A simple solution to this problems would be to just avoid the extra thread and simple use the thread that invokes subscribe. This way the user is in full control and can add whatever monitors/strategy she wants.