search

e-oj / Magic-Grid

A simple, lightweight Javascript library for dynamic grid layouts.
https://www.npmjs.com/package/magic-grid
MIT License
3.14k stars 144 forks source link

Removed jQuery + Switched to rollup #2

Closed imlinus closed 6 years ago

imlinus commented 6 years ago

Hi,

I have removed the jQuery dependency, and I have switched from webpack to rollup.

Rollup is for libs, webpack is for apps ;-)

Cheers, Linus

imlinus commented 6 years ago

Oh, plus I've used the https://standardjs.com style-guide for clean code 👍

e-oj commented 6 years ago

Great Work 👍 👍. I'll take out the ready function in grid.html because I want the test file to be as simple as possible. Thanks for the plug on rollup as well, I didn't even know it existed.

imlinus commented 6 years ago

Thank you @e-oj Sounds good, I'm sorry, I forgot to take it out when I was done testing, my bad 🐤

Rollup is a great tool for libraries, together with Bublé (by Rich Harris) it produces clean es5 code that tries to match the syntax as good as possible 👍

Btw, I just made a Vue.js port of your library. (still v.0.0.1 tho) Still a few bugs on initial rendering. I'll fix those after work :-)

Cheers! Linus

e-oj commented 6 years ago

Let me know once you're done with the Vue.js port so I can add a link to it in the readme.

e-oj commented 6 years ago

@imlinus Upgrade to the new version and see if that fixes the initial rendering issues

imlinus commented 5 years ago

Hey, https://github.com/imlinus/Vue-Magic-Grid, works smooth like butter for me!

e-oj commented 5 years ago

Clean work. I've added your link to the readme

imlinus commented 5 years ago

Awesome, thanks mate 💯