Added favicon to returned data

e-oj / grabity

Generate link previews from pages with Open Graph or Twitter Cards markup. Just grab it! 🎣

https://www.npmjs.com/package/grabity

MIT License

291 stars 15 forks source link

Closed joshfarrant closed 6 years ago

joshfarrant commented 6 years ago

Adds favicon to returned data (if it exists) as discussed in #4.

Let me know if you're happy with the way that the favicon has been included in the responses @e-oj.

All tests are passing 👍

e-oj commented 6 years ago

Looks good to me. Solid work. Thanks for the pr.

joshfarrant commented 6 years ago

Great, thanks for merging 👌

Any chance you could publish the new version to npm, if you haven't already? I'm hope to start using it right away!

joshfarrant commented 6 years ago

Whoops, I just realised that I didn't update the documentation in the README, sorry about that.

Would you like me to add the favicon in, or are you happy doing that?

e-oj commented 6 years ago

I was going to update the documentation and publish it. But feel free to carry out the update. I'll publish after that's merged