e-picsa / picsa-apps

Monorepo for building tools to support E-PICSA Apps
https://picsa.app
GNU General Public License v3.0
6 stars 2 forks source link

Feat(climate) - chart-specific tool configuration #159

Closed chrismclarke closed 1 year ago

chrismclarke commented 1 year ago

Description

Main Changes

Whilst running the workshop it became obvious that using the line-tool on climate charts drew some confusion going through the process of counting points above/below line and drawing conclusions. For rainfall graphs the focus is usually on exceedence (points above) but start date usually focus is on whether the season starts 'before' (points below).

Previously we have tried to just flip the colours for the specific graph, however the code to do this was quite confusing and not applied consistently when adding new graphs.

So instead this PR tries to make line and probability tools more configurable on a per-chart basis, including specific colours of points above/below, labels to apply and ordering on the page.

Additional changes

Discussion

Preview

https://picsa-extension-toolkit--pr159-feat-climate-tool-up-mb13rzr6.web.app/

Screenshots / Videos

Before - tools would typically only reference points above the line and infer conclusion (incorrectly in case of start date) picsa app_climate_site_petauke_view=start(Picsa) (2)

After - tools more flexible to change colours, show info for both above/below and change label relevant to context localhost_4200_climate_site_petauke_view=start(Picsa)

localhost_4200_climate_site_chipata_view=start(Picsa)

Demo video

Chipata.webm

github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit fec729e):

https://picsa-extension-toolkit--pr159-feat-climate-tool-up-mb13rzr6.web.app

(expires Wed, 16 Aug 2023 18:56:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2435c4a5f2b9750fe5c819a7a14bcf9433816983